Skip to content

fix Stream.read into buffer ignoring every second byte #8453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2022
Merged

fix Stream.read into buffer ignoring every second byte #8453

merged 1 commit into from
Jan 18, 2022
+1 −1

Conversation

INemesisI
Copy link
Contributor

@INemesisI INemesisI commented Jan 18, 2022 •
edited
Loading

As shown in #8452, the default implementation for int Stream::read (uint8_t* buffer, size_t maxLen) only writes every second byte into the given buffer.

fixes #8452

@d-a-v d-a-v mentioned this pull request Jan 18, 2022
Closed
@d-a-v d-a-v merged commit f4ef6fd into esp8266:master Jan 18, 2022
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
@INemesisI @hasenradball
fix Stream.read into buffer ignoring every second byte (esp8266#8452) (…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
bf21383 
…esp8266#8453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

default implementation for buffered Stream.read only reads every second byte
2 participants
@INemesisI @d-a-v